Fixed hardcoded cert and added the pdf download btn #739
Conversation
|
@hkirat yo check out this |
|
@TanmayDhobale This was already resolved at PR #728 for PNG |
|
@AyushShivhare79 yo i am alrdy working on this pr bro btw why u made 2 pr tho |
|
@TanmayDhobale But he created another issue to fix dynamic description i already created the PR for that, The Thing i fixed was Typo of verified, dynamic description new PDF certificate with dynamic description, download pdf button cleaned the design of certificate and many more you can look so, can you please close this PR? |
|
The typo of verified and description in center is still an issue in you PR although no latest certificate was added for PDF. @TanmayDhobale |
fixed bro |
|
This is my first step toward open source i already fixed all the things why are you working on the solved issue? let me kick start my journey @TanmayDhobale |
@AyushShivhare79 lol , bro i was Already working on this issue like he told me to do but its okay . |
|
So can you close this PR ser? @TanmayDhobale |
|
@TanmayDhobale I can't see he told you to fix this issue here #720 |
look my last marge pr |
|
He asked you for pdf one not for typo and dynamic description one ser, Also you didn't said you are working for pdf aswell there so, i fixed both before you @TanmayDhobale |
|
Accept it man. @TanmayDhobale Or let @hkirat Take care of this he knows the issue was already resolved. |
there is nothing to Accept dude
|
|
I am not playing, I just solved issue and created PR 12 hrs before, I would say don't waste time work on something else I just worry why would you like to solve the solved issue men? @TanmayDhobale |
@AyushShivhare79 bro i was Already working on this issue |
|
Its good but he did'nt assigned it to anyone so ig i solved it first and raised PR. Check #720 @TanmayDhobale |
cool bro best of luck . |
PR Fixes: btw ive deleted old cert