Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: certificate typo #720

Closed
hkirat opened this issue May 28, 2024 · 7 comments · Fixed by #728
Closed

bug: certificate typo #720

hkirat opened this issue May 28, 2024 · 7 comments · Fixed by #728
Labels
bug Something isn't working

Comments

@hkirat
Copy link
Contributor

hkirat commented May 28, 2024

Screenshot 2024-05-28 at 5 31 49 PM
@hkirat hkirat added the bug Something isn't working label May 28, 2024
@Smnthjm08
Copy link
Contributor

we have to edit the public/certificate.png only right? @hkirat

@hkirat
Copy link
Contributor Author

hkirat commented May 28, 2024

yeah that should do it
Whoever is doing this please make the description on the certificate dynamic as well
It should say 1-100 / 0-100 / 0-1 based on the correct course for the user

@Smnthjm08
Copy link
Contributor

@hkirat can you assign it to me?

@Smnthjm08
Copy link
Contributor

github

@4kshi7 4kshi7 mentioned this issue May 28, 2024
Closed
2 tasks
@AyushShivhare79 AyushShivhare79 mentioned this issue May 28, 2024
Closed
2 tasks
@Smnthjm08 Smnthjm08 mentioned this issue May 29, 2024
Closed
2 tasks
@AyushShivhare79
Copy link
Contributor

Created dynamic description and fixed the typo.

Screenshot from 2024-05-29 17-51-31

@AyushShivhare79 AyushShivhare79 mentioned this issue May 29, 2024
Merged
2 tasks
@AyushShivhare79
Copy link
Contributor

@hkirat Can you check this ?

@Smnthjm08
Copy link
Contributor

@AyushShivhare79 I'm a beginner to open source. Can you tell me how you run tests for the certificate? I tried the same way, but I couldn't get it to run.

@manishpali17 manishpali17 mentioned this issue May 30, 2024
Closed
2 tasks
@AyushShivhare79 AyushShivhare79 mentioned this issue May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@hkirat @Smnthjm08 @AyushShivhare79