Feat/mobile auth #772
Draft
Feat/mobile auth #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkirat Will be testing this thoroughly, and then mark it ready for review. We're disabling auth on local, so need to modify some code to test properly |
5 tasks
siinghd
requested changes
Jun 14, 2024
siinghd
requested changes
Jun 17, 2024
siinghd
requested changes
Jun 18, 2024
src/lib/middleware-utils.ts
Outdated
| if (token) { | ||
| try { | ||
| const payload: any = await verifyJWT(token); | ||
| request.nextUrl.searchParams.set('userId', payload.id); |
There was a problem hiding this comment.
why can't be this used in logout?
siinghd
reviewed
Jun 19, 2024
| @@ -3,26 +3,22 @@ import db from '@/db'; | |||
|
|
|||
| export async function POST(request: NextRequest) { | |||
| try { | |||
| // TODO: Get userid from somewhere not body | |||
There was a problem hiding this comment.
lets wait for this to be solved
|
@nimit9 any update on this? would like to close and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
middleware.tsto authorize mobile routesResolves #761
Checklist before requesting a review