Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Monorepo #787

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Conversation

hiteshsharma-gh
Copy link

Resolves #755

PR Fixes:

Checklist before requesting a review

  • I have performed a self-review of my code

@hiteshsharma-gh
Copy link
Author

hiteshsharma-gh commented Jun 15, 2024

@hkirat @siinghd resolved all conflicts

@hkirat hkirat requested a review from siinghd June 15, 2024 11:40
@siinghd
Copy link
Collaborator

siinghd commented Jun 15, 2024

@hkirat this will mess up all the existing PR's i think, don't know how to proceed here.

@siinghd
Copy link
Collaborator

siinghd commented Jun 15, 2024

@hiteshsharma-gh can you fix these conflicts? ill try to test it in local after that. Ill be stopping merging other PR's for now as they only create conflicts

@hiteshsharma-gh
Copy link
Author

hiteshsharma-gh commented Jun 15, 2024

@siinghd resolved conflicts
aside from that finally learned a bit about rebase after resolving so many conflicts

Copy link
Collaborator

@siinghd siinghd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husky is not setup properly, can we use daily code setting?
https://github.com/code100x/daily-code

Still need to test docker, without docker working fine for what i have tested for now...

will continue looking into this.

My only concern is if we merge this, it will mess up all the existing PR's

apps/next-frontend/.eslintrc.js Show resolved Hide resolved
packages/common/lib/find-content-by-id.ts Show resolved Hide resolved
@hiteshsharma-gh
Copy link
Author

husky was not a part of my initial pr it was added when merge other pr
will see if daily code settings work

@hiteshsharma-gh
Copy link
Author

Husky is not setup properly, can we use daily code setting? https://github.com/code100x/daily-code

Still need to test docker, without docker working fine for what i have tested for now...

will continue looking into this.

My only concern is if we merge this, it will mess up all the existing PR's

if we have to convert to monorepo then i don't think there's any other option
@hkirat what is your opinion

@hiteshsharma-gh
Copy link
Author

Husky is not setup properly, can we use daily code setting? https://github.com/code100x/daily-code

Still need to test docker, without docker working fine for what i have tested for now...

will continue looking into this.

My only concern is if we merge this, it will mess up all the existing PR's

done sir,
used daily code settings with some changes to make it work

@siinghd
Copy link
Collaborator

siinghd commented Jun 17, 2024

@hiteshsharma-gh thank you sir, will review this and test with docker asap

@shantanuSakpal
Copy link

whats the status? @siinghd

@shantanuSakpal
Copy link

shantanuSakpal commented Jul 8, 2024

i think this should be a priority, as people will continue raising pr s using existing structure. or if it still needs some work, but is something that is surely going to be implemented, then i suggest to add hiteshsharma-gh:turborepo in the contributing docs, so that we can follow this structure and do feature implementations, so that it will be less work to update the prs after merge

@hiteshsharma-gh
Copy link
Author

@shantanuSakpal hsingh is gonna merge it in some time after closing some prs

@shantanuSakpal
Copy link

Okay, great !

@hiteshsharma-gh
Copy link
Author

hiteshsharma-gh commented Aug 7, 2024

@siinghd
still-waiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Convert to a monorepo
5 participants