-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a Monorepo #787
base: main
Are you sure you want to change the base?
Make a Monorepo #787
Conversation
…slint packages/tsconfig packages/ui
…slint packages/tsconfig packages/ui
@hkirat this will mess up all the existing PR's i think, don't know how to proceed here. |
@hiteshsharma-gh can you fix these conflicts? ill try to test it in local after that. Ill be stopping merging other PR's for now as they only create conflicts |
@siinghd resolved conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Husky is not setup properly, can we use daily code setting?
https://github.com/code100x/daily-code
Still need to test docker, without docker working fine for what i have tested for now...
will continue looking into this.
My only concern is if we merge this, it will mess up all the existing PR's
husky was not a part of my initial pr it was added when merge other pr |
if we have to convert to monorepo then i don't think there's any other option |
done sir, |
@hiteshsharma-gh thank you sir, will review this and test with docker asap |
whats the status? @siinghd |
i think this should be a priority, as people will continue raising pr s using existing structure. or if it still needs some work, but is something that is surely going to be implemented, then i suggest to add |
@shantanuSakpal hsingh is gonna merge it in some time after closing some prs |
Okay, great ! |
Resolves #755
PR Fixes:
One App (next frontend)
Packages
database (prisma, migrations)
ui (shad cn components)
eslint
tsconfig
common (types, zodTypes, zodSchema, lib)
Others
Docker (Dockerfile and docker-compose.yml)
prettier
update Readme
github templates
file structure
lint and format
https://github.com/code100x/cms/assets/141833621/57d1f0a8-5d80-40d1-b771-715e72bc0b48
running locally
https://github.com/code100x/cms/assets/141833621/5f9ad591-9629-401f-b578-218e19c0ae63
running using docker
https://github.com/code100x/cms/assets/141833621/8f66ebb9-93e1-4ce4-984f-8dde00bb77ef
Checklist before requesting a review