Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent translation of addresses by Google Translate #1092

Closed
joshreisner opened this issue Mar 16, 2023 Discussed in #1090 · 7 comments
Closed

Prevent translation of addresses by Google Translate #1092

joshreisner opened this issue Mar 16, 2023 Discussed in #1090 · 7 comments

Comments

@joshreisner
Copy link
Contributor

Discussed in #1090

Originally posted by VickiB11 March 15, 2023
Our website recently added Google Translate so that the Spanish speaking groups can see the TSML meeting finder in Spanish. However, the meeting location, address, and region are incorrectly translated. Is there a way to tag the meeting finder not to translate when using Google Translate?

Vicki B
Georgia Al-Anon

Meetings using Google Translate

places to address (sorry) the issue:

  • table view
  • table view after ajax filter
  • map view
  • detail page left side
  • detail page right side

you can add class="notranslate" to the parent tag of the address, or wrap it in a span

@troybon
Copy link

troybon commented May 1, 2023

Hey Josh,

Do you have any timeline on a chance to put this enhancement into the system?

Thanks,
Troy

@joshreisner
Copy link
Contributor Author

@troybon to be honest, i dont think anyone is working on this right now, so no eta to share at this time.

i'm fully allocated to other projects for the time being. if anyone were to volunteer i don't think it would be a heavy lift

@SIA-WEBSUP
Copy link

@troybon , can you check if this be accomplished by applying the 'notranslate' CSS class to the widget?
Here's a couple of links that might be of interest:

gkovats added a commit to gkovats/tsml-ui that referenced this issue Nov 19, 2023
Tied to Issue:
code4recovery/12-step-meeting-list#1092

Wrap display of addresses with "notranslate" to
deny Google Translate from translating native
language addresses
@gkovats
Copy link
Collaborator

gkovats commented Nov 19, 2023

@joshreisner FYI I put a PR in for this here:
code4recovery/tsml-ui#348

Don't know the relationship between the two, assuming it has to merge in tsml-ui before the dist JS updates in this plugin. Let me know if I'm missing steps.

joshreisner pushed a commit to code4recovery/tsml-ui that referenced this issue Nov 19, 2023
* Add notranslate class to addresses

Tied to Issue:
code4recovery/12-step-meeting-list#1092

Wrap display of addresses with "notranslate" to
deny Google Translate from translating native
language addresses

* Removing console.info

* Cleanup empty className
@gkovats
Copy link
Collaborator

gkovats commented Dec 24, 2023

Just looking, if we're preventing translation of street address, likely should do these as well:

  • Location / Group: sometimes a repeat of the street address
  • Region: should likely follow address, since it also uses proper geographic names

image

The others, probably safe to attempt translation. It's hard to tell with all groups / meeting names, and fuzzy nature of auto translate.

This make sense, do Location / Group, Address, and Region? It looks like a very small change, just clarifying exact change.

@joshreisner
Copy link
Contributor Author

yes that sounds consistent with the original request

However, the meeting location, address, and region are incorrectly translated. Is there a way to tag the meeting finder not to translate when using Google Translate?

@joshreisner
Copy link
Contributor Author

this issue should be fixed now by #1290 - thanks @gkovats !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants