Add notranslate class to addresses #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tied to Issue: code4recovery/12-step-meeting-list#1092 Wrap display of addresses with "notranslate" to deny Google Translate from translating native language addresses
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joshreisner
requested changes
Nov 19, 2023
joshreisner
reviewed
Nov 19, 2023
|
@joshreisner updated the two things. Not sure if you want commits squashed in PR, some repos ask for that. Let me know if anything else is outstanding. |
|
thanks @gkovats ! i have to merge it because the tests aren't passing - we haven't refactored those from the last pr yet i'll 'squash & merge' - no need to squash PRs before the merge though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tied to Issue:
code4recovery/12-step-meeting-list#1092
First PR, could be missing some steps, glad to adjust and fix. The issue was Google Translate goes nuts and translates native language addresses to the target language, but this obfuscates addresses. GPS / map tools drive off native language addresses.
Wrapping display of addresses with "notranslate" to deny Google Translate from translating native language addresses. This comes from the Issue, assuming this is sufficient - hard to test locally as Google Translate requires a public site.