Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2feature/27-Localise-The-Home-Page #28

Closed

Conversation

lloy0076
Copy link

@lloy0076 lloy0076 commented Jul 2, 2022

First pass at localisation.

Note there's no french/spanish...

First pass at localisation.

Note there's no french/spanish...
@lloy0076 lloy0076 mentioned this pull request Jul 2, 2022
Remove the comment to get rid of the horizontal line...
@joshreisner
Copy link
Contributor

thanks, i have some time to look at this now. in order to merge this i'd want to

  1. make it so interface language is settable somehow
  2. add french and spanish with google translate
  3. take out the page numbering feature

do you want to do that or otherwise im happy to

seems like making it settable is the only one that's not super clear. perhaps to start it we would just use routes and not make ui changes:

pdf.code4recovery.org
pdf.code4recovery.org/es
pdf.code4recovery.org/fr

@lloy0076
Copy link
Author

Making it configurable would be good.

I'm happy to make it respond to /es and /fr but I'm pressed for time until next year. That said, given that this is only a few week's away, if that timeframe is OK, I can do it.

I see removing the page numbering feature as a DIFFERENT PR, unless you mean it has already been removed and so it doesn't need a translation any longer?

@lloy0076
Copy link
Author

NB. My French is good enough to spot any silly translations; and I can understand enough Spanish to catch any egregious errors.

It would be useful to find a "proper translator" to double check; given the type of organisation this serves, there's probably several who would be willing to double check the Google translate as a way of contributing back.

@joshreisner
Copy link
Contributor

great, thanks. if you could take it to the finish line next year that'd be terrific

you added some page numbering logic as part of this PR that i would prefer to handle separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants