Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Recipients in chat rooms #79

Closed
footnote opened this issue Sep 28, 2015 · 9 comments
Closed

Multiple Recipients in chat rooms #79

footnote opened this issue Sep 28, 2015 · 9 comments
Assignees

Comments

@footnote
Copy link
Collaborator

We expected to receive one participant or partner in the room object, where to we could be able to know that this is the person I should talk with, but I'm wondering why do we receive multiple participants in the same room as follows:

{
_id: "560533242dfd982100585110",
__v: 11,
participants: [
{
_id: "558dd5195c99c61400e2c69b",
username: "string",
password: "$2a$09$k6DSq.ZjbFx1YBSN.ujpFuh9rbZrCwoQ0UcrtRDnE3Yb7un3/riUS",
__v: 0,
follows: [ ],
devices: [ ],
interests: [
"yogaBikram"
],
token: {
expires: "2015-06-26T22:41:29.390Z",
value: "FO1nkP05OgHSSA0ASq"
}
},
{
_id: "55988af5c59137140058c28d",
username: "kiks",
password: "$2a$09$zc6JhF5Tg3SZHbLqCC0W3eaG5FZy1pDkzmqGgAbLVj8hsh3Qe4GtC",
__v: 0,
follows: [ ],
devices: [ ],
interests: [
"yogaBikram"
],
token: {
expires: "2015-07-05T01:40:05.108Z",
value: "cNuWAFAmEX69MIlOsx"
}
}
],
createDate: "2015-09-25T11:42:28.033Z"
}

as well as a lot of wasted information that used such as:
follows array, devices array, interests of that user, token, expiry of the token, value, password

@avishaan
Copy link
Owner

When a user starts a conversation with another user, even if user2 hasn't responded, they should be considered a participant of the conversation and be shown in the participants array.

@avishaan
Copy link
Owner

avishaan commented Oct 1, 2015

can someone confirm this is for the route conversations/{conversationId} ? @ShadiFares. Currently that route is returning a participants array that includes all participants regardless of whether or not they have responded.

avishaan added a commit that referenced this issue Oct 1, 2015
@footnote
Copy link
Collaborator Author

footnote commented Oct 1, 2015

The route is GET /v1/conversations

@avishaan
Copy link
Owner

avishaan commented Oct 1, 2015

ah, got it!

avishaan added a commit that referenced this issue Oct 1, 2015
issue as the participants are being returned regardless of whether or
not they have responded
@avishaan
Copy link
Owner

avishaan commented Oct 1, 2015

that route also seems to be returning all the participants regardless of whether or not they responded back.

@footnote
Copy link
Collaborator Author

footnote commented Oct 2, 2015

Conversation that has id 5609a798182a69e70096e3f1 contains 1 participant as shown in the attached screenshot, I thought the scenario mentioned in our meeting was the reason behind this...

You can get this response from this route
http://lighttribe-dev.herokuapp.com/api/v1/conversations?access_token=cNuWAFAmEX69MIlOsx

screen shot 2015-10-03 at 1 15 17 am

@avishaan
Copy link
Owner

avishaan commented Oct 2, 2015

I think you might not be adding a recipient in the message correctly when you create it. Currently we aren’t checking that field. I can add that in to make sure. If you don’t add a recipient for the message then you will likely end up talking to yourself.

On Oct 2, 2015, at 4:16 PM, footnote.consulting notifications@github.com wrote:

Conversation that has id 5609a798182a69e70096e3f1 contains a conversation with 1 participant as shown in the attached screenshot, I thought the scenario mentioned in our meeting was the reason behind this...

You can get this response from this route
http://lighttribe-dev.herokuapp.com/api/v1/conversations?access_token=cNuWAFAmEX69MIlOsx http://lighttribe-dev.herokuapp.com/api/v1/conversations?access_token=cNuWAFAmEX69MIlOsx
https://cloud.githubusercontent.com/assets/7980253/10259755/44afa61c-696c-11e5-8aef-7b92e5d5cc56.png

Reply to this email directly or view it on GitHub #79 (comment).

@avishaan avishaan assigned footnote and unassigned avishaan Oct 15, 2015
@avishaan
Copy link
Owner

Please verify this is now closed based on everyone's understanding.

@avishaan
Copy link
Owner

@footnote can we confirm this is closed?

@avishaan avishaan closed this as completed Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants