Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuckyNumber #188

Merged
merged 5 commits into from
Dec 14, 2017
Merged

LuckyNumber #188

merged 5 commits into from
Dec 14, 2017

Conversation

Priyangshuyogi
Copy link
Contributor

Thank you for your contribution. Please provide the details requested below.

185

link to the issue this pull request addresses #185

SHORT DESCRIPTION

i have added a new folder named LuckyNumber to the math folder in Competitive Coding.

@prateekiiest
Copy link
Member

can you please elaborate what you are working on @Priyangshuyogi ?

@Priyangshuyogi
Copy link
Contributor Author

I am writing on some math based Algorithms which are often used in Competitive programming.

@Priyangshuyogi
Copy link
Contributor Author

I am writing theses Algorithms in the math folder under competitive programming section.

Copy link
Member

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Just some changes.

It should be a README.md file not that extension that you gave 😃

@Priyangshuyogi
Copy link
Contributor Author

Thank you 😃. I am fixing it.

@Priyangshuyogi
Copy link
Contributor Author

Priyangshuyogi commented Dec 13, 2017

okay sir. I have fixed it. Please merge it.

Copy link
Member

@prateekiiest prateekiiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎆

@prateekiiest prateekiiest merged commit 6df8707 into codeIIEST:master Dec 14, 2017
@Priyangshuyogi Priyangshuyogi changed the title Myrepo LuckyNumber Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants