-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove firing redundant change event for setValue #596
Conversation
61e9575
to
a56d1ca
Compare
@MegaUkrainian There are some failing tests:
Can you fix it? |
@asolntsev sorry, I forgot to mention, @MegaUkrainian have already fixed these tests. We disscused that in a private conversation. Thank you so much to @MegaUkrainian for his work! But I am afraid that such changes will break end users test in a similar way as they broke some selenide tests. |
Sorry, but I cannot understand why change event is redundant??? |
The main point here is that user does not trigger change event explicitly, it is done by browser according to user actions. Sending change event after sendKeys is an overhead. |
Again, people already use and rely on existing change event! |
Explicitly triggering "change event" - it's a hack and non-native behaviour.
Do you have any statistics on explicit usage of such event? Is it worth making optional such behaviour and overload the number of options in config? |
|
If they even do not know, it means that it is not crucial for them. A browser will trigger this event by default. |
@MikeShysh @BorisOsipov As much as I see, some tests are still failing: integration.PageWithJQuery.selectByXpath |
fa18dc5
to
16135c6
Compare
e428dad
to
fe1887e
Compare
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
============================================
+ Coverage 61.89% 63.36% +1.47%
- Complexity 828 861 +33
============================================
Files 154 154
Lines 2892 2981 +89
Branches 281 290 +9
============================================
+ Hits 1790 1889 +99
+ Misses 995 991 -4
+ Partials 107 101 -6
Continue to review full report at Codecov.
|
@MikeShysh @BorisOsipov I agree with you, Probably we should add some flag for keeping the previous behavior (let name it deprecated if you want)? P.S. I tried to run tests in my current projects - some of them failed. And yes, these are bad tests. :) |
@asolntsev, @MikeShysh, @BorisOsipov I propose to overload |
Hi, @rosolko thank you for your interest in this PR. However, to my mind, your solution a bit excessive from usability point of view. I see special flag to disable triggering change event is more user friendly |
I agree with @MikeShysh, we discussed it some time ago and decided to merge it with special flag to disable triggering. P.S.
From my point of view it is bad practices to add bool parameters to method :) In most cases it indicates that something wrong with your design\api |
@MikeShysh @BorisOsipov |
yeah, I will do it, when I have time =) |
it seems to be a chrome own image cache
Enable sandbox for chrome.
…ethod for SelenideElement.
Add series of unit tests
…elenide#705) * Adding possibility to make screenshot of SelenideElement of WebElement which is inside iframe * Added tests * Added same behavior as for existing screenshoting functionality in case if element doesn't exist inside iframe * Now taking into account vertical scroll bar for partially visible elements
…xing existing violations
Adding static analysis for avoiding start import for main package
Method to check if page is scrolled to the bottom
@MikeShysh would you mind to update your PR according requested changes? |
…nsistent" This reverts commit 1035d28. because it broke `./gradlew grid` - it seems that Selenium Grid tests are broken with a newer jetty
Upgrade dependencies
@BorisOsipov Yeah, I will try to find time for this weekend. If you can to do it now, feel free to update PR |
Closed in favor of #718 |
No description provided.