Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get current "User-Agent" for browser session. Related to #639 #657

Closed
wants to merge 4 commits into from
Closed

Conversation

rosolko
Copy link
Collaborator

@rosolko rosolko commented Dec 28, 2017

Proposed changes

Add "User-Agent" header when downloading file. Related to #639

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Set User-Agent for HttpGet in DownloadFileWithHttpRequest.
@rosolko rosolko changed the title Add ability to get current "User-Agent" for browser session Add ability to get current "User-Agent" for browser session. Related to #639 Dec 28, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 64.34% when pulling ee488d3 on rosolko:user_agent into 5a8d489 on codeborne:master.

@codecov-io
Copy link

codecov-io commented Dec 28, 2017

Codecov Report

Merging #657 into master will increase coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #657     +/-   ##
===========================================
+ Coverage     60.49%   60.59%   +0.1%     
- Complexity      771      772      +1     
===========================================
  Files           148      148             
  Lines          2749     2751      +2     
  Branches        270      270             
===========================================
+ Hits           1663     1667      +4     
+ Misses          981      980      -1     
+ Partials        105      104      -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/codeborne/selenide/Selenide.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rne/selenide/impl/DownloadFileWithHttpRequest.java 79.72% <100%> (+0.27%) 15 <0> (ø) ⬇️
...e/selenide/impl/WebDriverThreadLocalContainer.java 82.6% <0%> (+2.17%) 31% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8d489...607eef0. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 64.377% when pulling 607eef0 on rosolko:user_agent into 5a8d489 on codeborne:master.

@rosolko
Copy link
Collaborator Author

rosolko commented Dec 29, 2017

I don't know why reason, but codecov/patch won't pass :(

@BorisOsipov
Copy link
Member

@rosolko relax and don't care :)

@BorisOsipov
Copy link
Member

Thanks @rosolko
Merged b9a8840

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "User-Agent" header when downloading file
5 participants