-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme #138
docs: update readme #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 81.44% 81.44%
=======================================
Files 29 29
Lines 469 469
=======================================
Hits 382 382
Misses 87 87 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments re: links that were accidentally dropped, but overall looks good! Thanks for the edits!
@@ -3,88 +3,108 @@ | |||
![Test](https://github.com/codebuddies/django-concept/workflows/Test/badge.svg) | |||
[![codecov](https://codecov.io/gh/codebuddies/backend/branch/master/graph/badge.svg)](https://codecov.io/gh/codebuddies/backend) | |||
|
|||
**Note:** This project is currently _in development_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, good note :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ta
|
||
The API spec all the proof-of-concepts: https://app.swaggerhub.com/apis-docs/billglover/CodeBuddies/0.0.1 | ||
- [Background] | ||
- [The API spec all the proof-of-concept] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be linking to codebuddies/codebuddies#1136 and https://app.swaggerhub.com/apis-docs/billglover/CodeBuddies/0.0.1 respectively, right?
So:
The [API spec](https://app.swaggerhub.com/apis-docs/billglover/CodeBuddies/0.0.1) of our proof-of-concept
etc.
## Setup | ||
|
||
Although it is possible to run this locally, we recommend you run CodeBuddies locally using Docker. We assume you have Docker installed, but if not head on over to the Docker [Getting Started](https://www.docker.com/products/docker-desktop) guide and install Docker for your operating system. | ||
We recommend you run CodeBuddies locally using Docker. We assume you have Docker installed, but if not head on over to the Docker [Getting Started] guide and install Docker for your operating system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL "Getting Started" is linking to is missing here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link has been moved to the bottom https://github.com/codebuddies/backend/compare/feature/readme-update#diff-04c6e90faac2675aa89e2176d2eec7d8R233
I've used a reference style link format for readability. See [link text itself]: http://www.reddit.com
here https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, TIL! Thanks, didn't know it was possible to do this in markdown before, for some reason 😅
README.md
Outdated
- update resource | ||
- list resource | ||
- search resources | ||
- [ ] save resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized we can tick off ALL of these checkmarks, haha 🎉 So we can put an "x" next to each of them!
The only one we can't tick off yet is [ ] Calendar/hangouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
To stop the application and remove all containers, run the following. | ||
6. You can populate the database with some random test data for development purposes by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, one idea here: maybe it would be helpful to add @chris48s' documentation about the init_data --help
command:
$ docker-compose run --rm app ./manage.py init_data --help
usage: manage.py init_data [-h] [--clear-db] [--num-users NUM-USERS]
[--num-tags NUM-TAGS]
[--num-resources NUM-RESOURCES] [--version]
[-v {0,1,2,3}] [--settings SETTINGS]
[--pythonpath PYTHONPATH] [--traceback]
[--no-color] [--force-color]
Initialize the DB with some random fake data for testing and development
optional arguments:
--clear-db Clear existing data from the DB before creating test
data
--num-users NUM-USERS
Number of `User` objects to create (default 10)
--num-tags NUM-TAGS Number of `Tag` objects to create (default 10)
--num-resources NUM-RESOURCES
Number of `Resource` objects to create (default 10)
-v {0,1,2,3}, --verbosity {0,1,2,3}
Verbosity level; 0=minimal output, 1=normal output,
2=verbose output, 3=very verbose output
This is from his PR at #129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs: Thanks for the feedback @lpatmo, I've added the requested changes as a second commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for making these changes @tgrrr :) And for pointing out the existence of reference-style links!
No description provided.