Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/readme update #143

Merged
merged 5 commits into from
Jul 19, 2020
Merged

Feature/readme update #143

merged 5 commits into from
Jul 19, 2020

Conversation

tgrrr
Copy link
Contributor

@tgrrr tgrrr commented Jun 2, 2020

I added some of the links to the spec docs that I had in the CB slack channel. Feel free to add any others you have during this update.

I also updated the link to PR127, it was pointing to PR129

README.md Outdated
```

5. Create a superuser so that you can log into http://localhost:8000/admin by running the following in your terminal: `$ docker-compose run --rm app ./manage.py createsuperuser`
[See PR 127]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to say PR 129 so it can point to #129

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this relate to the custom ./manage.py script and its random test data?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose run --rm app ./manage.py init_data creates test data for things like users and resources, while docker-compose run --rm app ./manage.py createsuperuser creates a superuser that lets you log in to /admin and control the various data on the app.

(Let me know if I answered your question/if that's what you were asking about!)

Copy link
Member

@lpatmo lpatmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending merge conflict resolutions :)

I'm a little confused by how the left-hand side of the PR diff seems to indicate that more was changed than I see (maybe formatting?) but the right-hand side looks good!

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files          29       29           
  Lines         491      491           
=======================================
  Hits          411      411           
  Misses         80       80           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd61659...c151b41. Read the comment docs.

@lpatmo lpatmo merged commit 5b667e0 into master Jul 19, 2020
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lpatmo added a commit that referenced this pull request Jul 19, 2020
* Feature/readme update (#143)

* docs: update readme

* docs: update based on Linda's (@lpatmo) feedback

* docs: added reference links to spec docs from Slack, updated link to PR127

* docs: backend issue from 129 -> issue 127

Co-authored-by: Linda <lindapnotes@gmail.com>

* Add license (#136)

Can't believe I forgot to do this from the start, heh. We need to make sure we have a license before we apply to https://sentry.io/for/open-source/

* Create FUNDING.yml (#135)

While looking for something unrelated I noticed that it was pretty easy to set up a "sponsor" button for this repo. I kept the original template in there in case we wanted to add things like the github usernames of individual core contributors (up to 4 allowed).

Co-authored-by: Phil <phil@tgrrr.com>
@nuageklow
Copy link
Contributor

quick update on the docker django management commands testing on Win10Pro and WSL - all manage.py related commands do not work on both.

figuring out alternative commands for both OS and will update the README.md when done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants