Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Local Development with localtunnel and Slack #42

Merged
merged 3 commits into from Mar 7, 2018

Conversation

angelocordon
Copy link

@angelocordon angelocordon commented Mar 5, 2018

Setup framework for being able to develop locally and connect to a Slack channel via their APIs.

@angelocordon angelocordon self-assigned this Mar 5, 2018
@angelocordon angelocordon added Discussion Needed feedback needed Looking for critiques or feedback chore labels Mar 5, 2018
@angelocordon angelocordon force-pushed the chore/setup-local-development branch from e5788e0 to 962f651 Compare March 6, 2018 13:34
@angelocordon angelocordon changed the title [WIP] Setup Local Development with localtunnel and Slack Setup Local Development with localtunnel and Slack Mar 6, 2018
Copy link
Collaborator

@stain88 stain88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, i think Step 4 of "Set up greetbot" needs to be moved up to before Step 2 of "Grab your tokens for your .env file", since you don't get the tokens until the app is installed, but you can't install the app without a bot user. There's also a typo in Slash Commnands.
Still need to go through the events, as this branch is now out of date with development, and at the very least, package.json is different, so haven't run the install process yet.

package.json Outdated
@@ -22,6 +24,6 @@
"app-module-path": "^2.x"
},
"devDependencies": {
"nodemon": "^1.17.1"
"localtunnel": "^1.8.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma here also seems to be an issue for me

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, why has nodemon gone? needs to stay in

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I think that's a merge conflict on my end, will put it back in 👍

@stain88
Copy link
Collaborator

stain88 commented Mar 6, 2018

Another thing to note: due to our use of await/async, people must have node version ^8.x installed - don't know if that should be in Chapter 1 setup, or at the top of the greetbot page.

@stain88
Copy link
Collaborator

stain88 commented Mar 6, 2018

One more: when setting up commands, need to make sure "Escape channels, users, and links sent to your app" is checked, otherwise our parser breaks

localtunnel allows for local server to be exposed to the internet and be
connected to Slack's API. Create a separate Node process for localtunnel to
run in parallel with Express.

Add an .env.example file.
@angelocordon angelocordon force-pushed the chore/setup-local-development branch from 962f651 to d990ce7 Compare March 7, 2018 14:10
@stain88 stain88 merged commit 739c9d1 into development Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants