Fix account deletion. #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.9.5 Release
Release 0.9.6
Release 0.9.7
railsstudent
approved these changes
Dec 19, 2017
|
@railsstudent thanks for the review. |
lpatmo
added
[state] closed
lpatmo
added a commit
that referenced
this pull request
Dec 26, 2017
* Issue 691 hangout participant count (#719) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * Issue-691. Show number of participants in 24/7 hangout Issue-691. show number of hangout participants in all study group and my study group pages issue-691. Only decrement participant count when the logged in user joins the hangout room Issue-691 Decrement participant count when value is positive * Remove unique index comment * fix 'participants_count' of undefined console err * Get rid of session variable * Move server-side logic to new files * Enable seed data * minor improvements * Show laptop icon when people join 24/7 hangout * Fix account deletion. (#745) * fix typo * Schedule hangout default studygroup name (#743) * Default study group name when schedule a hangout in single study group duplicate hangout in single study group * Default study group name value is not displayed in dropdown input area unless trigger('change') is fired * Fixed error * Issue 667 create slack page (#744) * Create new Slack page * Add helpful links * Minor content edits! Note: I removed the slackin plugin in favor of a direct link because I noticed some positioning issues with the form that appears after a user clicks on the plugin; it's sometimes out of reach, and will make the user think that nothing happened. * Show study group name in disabled input box in modal (#748) * Refactoring 1 (#752) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * refactor (routes) remove subs from router level * refactor (hangout_logged_out) make use of new syntax * refactor (hangouts) - remove dead code, restructure single hangout view
lpatmo
added a commit
that referenced
this pull request
Jan 1, 2018
* Issue 691 hangout participant count (#719) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * Issue-691. Show number of participants in 24/7 hangout Issue-691. show number of hangout participants in all study group and my study group pages issue-691. Only decrement participant count when the logged in user joins the hangout room Issue-691 Decrement participant count when value is positive * Remove unique index comment * fix 'participants_count' of undefined console err * Get rid of session variable * Move server-side logic to new files * Enable seed data * minor improvements * Show laptop icon when people join 24/7 hangout * Fix account deletion. (#745) * fix typo * Schedule hangout default studygroup name (#743) * Default study group name when schedule a hangout in single study group duplicate hangout in single study group * Default study group name value is not displayed in dropdown input area unless trigger('change') is fired * Fixed error * Issue 667 create slack page (#744) * Create new Slack page * Add helpful links * Minor content edits! Note: I removed the slackin plugin in favor of a direct link because I noticed some positioning issues with the form that appears after a user clicks on the plugin; it's sometimes out of reach, and will make the user think that nothing happened. * Show study group name in disabled input box in modal (#748) * Refactoring 1 (#752) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * refactor (routes) remove subs from router level * refactor (hangout_logged_out) make use of new syntax * refactor (hangouts) - remove dead code, restructure single hangout view * Add 'add to google calendar' button that opens up link with event details from hangout, including meet.jit.si location (#755) * Display fallback image if image url of contributor is broken (#756) * Issue 547 redesign of /hangouts page (#757) * redesigned header area * hangouts area now uses flexbox + big redesign of cards area * adjust column display on profile page * completed hangout cards do not need to be very tall; also, hide meta content on hover * add popover descriptions for silent/collaboration/teaching icon keys * grammar correction * update hangout-faq a bit more, and give it its own route * capitalization fixes * adjust hover behavior of btn-block * fix up hangout cards in study groups * update faq content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account deletion functionality is broken because of a typo. This PR fixes it.
H/t to Void for pointing out in slack.