Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to work with laravel 5.5 #17

Merged
merged 8 commits into from Oct 28, 2017
Merged

Fix to work with laravel 5.5 #17

merged 8 commits into from Oct 28, 2017

Conversation

adrianogl
Copy link
Contributor

No description provided.

@hernandev
Copy link
Member

Not sure what this PR does, can you help me figure it out?

Thanks

@hernandev
Copy link
Member

@adrianogl Two PR's was actually opened to solve this issue.

The correct way of solving it is actually by having both methods and one should call the another, this way the package will be compatible with multiple Laravel versions.

Let'me know if you can include this so I can merge the request.

Otherwise, I'll do it myself and close this.

Thanks anyway.

@adrianogl
Copy link
Contributor Author

Done ;)

@hernandev hernandev changed the base branch from master to develop October 26, 2017 03:34
@hernandev
Copy link
Member

commits must enter on develop always.

Just noticed I can change that myself @flyingluscas

@hernandev hernandev merged commit 0022793 into codecasts:develop Oct 28, 2017
@hernandev
Copy link
Member

gonna release this in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants