support protected Authenticatable identifier #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey man, it's great you liked it. It's great your pull request, indeed, the way it was would mostly work only with Eloquent. Gonna accept your PR as soon I push some pending local code tomorrow. Thanks for it. |
|
Accept please. |
|
sorry forgot about this one. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using this package with
laravel-doctrine, and I get error if my Authenticable entity have a protected/private identifier.Now, the token manager use the identifier getter function rather than accessing it directly.
PS: thanks for the package, it is awesomely simple.