Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#Milestone5 #4

Merged
merged 4 commits into from
Nov 20, 2020
Merged

#Milestone5 #4

merged 4 commits into from
Nov 20, 2020

Conversation

codecell
Copy link
Owner

What does this PR do?

  • This is for TSE review of milestone 5 implementation

Quick UI preview

Changes Made

  • Followed all the steps to implement milestone 5 requirements
  • Augmented the user experience to display operation sign at top of the display panel.

How can this be manually tested?

  • After cloning this repo
  • cd into project folder
  • create a local branch named milestone5
  • Run yarn install or npm install to add project dependencies
  • Run yarn startl or npm start to compile and serve a local build on localhost:3000 or any other free port available to react app

MuriloRoque
MuriloRoque approved these changes Nov 20, 2020
View reviewed changes
Copy link

@MuriloRoque MuriloRoque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢

Hello @codecell 👋

Congratulations, your project is approved 👏 👏 👏

You may merge, good luck with your next projects 🚀

Murilo Roque Paiva da Silva

Twitter Follow

@codecell codecell merged commit ef92638 into develop Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuriloRoque MuriloRoque MuriloRoque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecell @MuriloRoque