Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unecessary empty check on watchedCustomService #152

Merged
merged 2 commits into from Nov 27, 2019

Conversation

Caps-Looking
Copy link
Contributor

Fix #151

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #152 into master will decrease coverage by 0.75%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
- Coverage     85.88%   85.13%   -0.76%     
+ Complexity      298      297       -1     
============================================
  Files            51       51              
  Lines           666      666              
  Branches         35       35              
============================================
- Hits            572      567       -5     
- Misses           63       67       +4     
- Partials         31       32       +1
Impacted Files Coverage Δ Complexity Δ
.../chaos/monkey/configuration/AssaultProperties.java 90.9% <0%> (ø) 24 <1> (ø) ⬇️
...haos/monkey/component/ChaosMonkeyRequestScope.java 95.12% <100%> (+2.43%) 16 <0> (ø) ⬇️
...ring/boot/chaos/monkey/assaults/MemoryAssault.java 83.07% <0%> (-9.24%) 15% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cacfb...befdbe2. Read the comment docs.

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Caps-Looking

Appreciate the fix, thanks! 👍
It would be cool if you could add yourself into the Changelog.

After that we can merge your change 😃

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fast update
LGTM 🏂

@WtfJoke WtfJoke merged commit 1760c8b into codecentric:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary Empty-Check on watchedCustomService
4 participants