Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing AssaultPropertiesUpdate validation #251

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Jul 23, 2021

What:
Fix missing AssaultPropertiesUpdate validation

Why:
missing validation

How:
Added validator annotation

Checklist:

  • [N/A] Documentation added
  • Changelog updated
  • Tests added
  • Ready to be merged

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐛

@codecov-commenter
Copy link

Codecov Report

Merging #251 (e21fdf3) into main (1064c9c) will increase coverage by 13.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #251       +/-   ##
=============================================
+ Coverage     67.47%   81.46%   +13.99%     
- Complexity      307      366       +59     
=============================================
  Files            76       76               
  Lines           944      939        -5     
  Branches         50       52        +2     
=============================================
+ Hits            637      765      +128     
+ Misses          276      141      -135     
- Partials         31       33        +2     
Impacted Files Coverage Δ
.../chaos/monkey/configuration/AssaultProperties.java 91.30% <ø> (-2.03%) ⬇️
...haos/monkey/configuration/ChaosMonkeySettings.java 85.71% <ø> (+14.28%) ⬆️
...chaos/monkey/endpoints/ChaosMonkeyJmxEndpoint.java 86.36% <ø> (ø)
...haos/monkey/endpoints/ChaosMonkeyRestEndpoint.java 91.30% <ø> (+91.30%) ⬆️
.../monkey/endpoints/dto/AssaultPropertiesUpdate.java 97.05% <ø> (ø)
...s/monkey/endpoints/dto/ChaosMonkeySettingsDto.java 100.00% <ø> (ø)
.../monkey/endpoints/dto/WatcherPropertiesUpdate.java 93.75% <ø> (ø)
...ints/dto/validation/AssaultExceptionValidator.java 83.33% <ø> (ø)
.../AssaultPropertiesUpdateLatencyRangeValidator.java 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1064c9c...e21fdf3. Read the comment docs.

@WtfJoke WtfJoke merged commit 44440c7 into codecentric:main Jul 23, 2021
@F43nd1r F43nd1r deleted the fix_missing_assault_properties_update_validation branch August 20, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants