Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvnw files update #252

Merged
merged 4 commits into from
Jul 29, 2021
Merged

mvnw files update #252

merged 4 commits into from
Jul 29, 2021

Conversation

MatthewBerk
Copy link
Contributor

What:
Updated mvnw files to utilize maven wrapper 0.5.6 instead of 0.5.5

Why:
#246 (comment)

How:
Executing mvn -N io.takari:maven:wrapper

Checklist:

  • Documentation added N/A
  • Changelog updated
  • Tests added N/A
  • Ready to be merged

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #252 (6ecea01) into main (8d49d7a) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #252      +/-   ##
============================================
- Coverage     76.30%   76.20%   -0.10%     
+ Complexity      380      378       -2     
============================================
  Files            78       78              
  Lines          1034     1034              
  Branches         66       66              
============================================
- Hits            789      788       -1     
  Misses          211      211              
- Partials         34       35       +1     
Impacted Files Coverage Δ
...ring/boot/chaos/monkey/assaults/MemoryAssault.java 92.53% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d49d7a...6ecea01. Read the comment docs.

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this @MatthewBerk. The changes looks as expected, expect the changelog needs some improvements (see my comments) :)

As a tip for future. Always create a separate branch for your contributions. So you can keep your main branch up to date with upstream/original repository (either through git tools or github ui, see screenshot)

grafik

chaos-monkey-docs/src/main/asciidoc/changes.adoc Outdated Show resolved Hide resolved
chaos-monkey-docs/src/main/asciidoc/changes.adoc Outdated Show resolved Hide resolved
@WtfJoke WtfJoke merged commit b5f75d1 into codecentric:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants