Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in KillAppAssault when using netty #260

Merged
merged 3 commits into from Aug 17, 2021

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Aug 13, 2021

What:
Ignore interrupts and continue wait in KillAppAssault

Why:
#82

How:
additional try/catch

Checklist:

  • N/A Documentation added
  • Changelog updated
  • N/A Tests added
  • Ready to be merged

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #260 (29734ee) into main (5a70c14) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #260      +/-   ##
============================================
- Coverage     76.15%   75.81%   -0.35%     
- Complexity      382      383       +1     
============================================
  Files            80       80              
  Lines          1040     1046       +6     
  Branches         66       66              
============================================
+ Hits            792      793       +1     
- Misses          213      218       +5     
  Partials         35       35              
Impacted Files Coverage Δ
...ing/boot/chaos/monkey/assaults/KillAppAssault.java 50.00% <0.00%> (-16.67%) ⬇️
...ring/boot/chaos/monkey/assaults/SizeConverter.java 75.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a70c14...29734ee. Read the comment docs.

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the change is simply ignoring any interruptedexception?

LGTM

@WtfJoke WtfJoke linked an issue Aug 17, 2021 that may be closed by this pull request
@WtfJoke WtfJoke merged commit 3f54af5 into codecentric:main Aug 17, 2021
@F43nd1r
Copy link
Member Author

F43nd1r commented Aug 17, 2021

So the change is simply ignoring any interruptedexception?

Exactly - apparently netty interrupts all threads, but we want to wait anyway, so ignore that.

@F43nd1r F43nd1r deleted the issue_82 branch August 20, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KillAppAssault is not working
3 participants