Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack all public methods when watchedCustomService is a class reference #271

Merged
merged 2 commits into from Aug 27, 2021

Conversation

WtfJoke
Copy link
Contributor

@WtfJoke WtfJoke commented Aug 27, 2021

What:
#265 From reading the docs I would have expected when I set watchedCustomServices to a class reference all public methods of that class are attacked. But up so far it was only possible to specify references to methods

Why:
Its more straight forward if you reference a class (or now even a package), that all methods of that class gets attacked.

How:
By checking if the simple name of the proxied method starts with any string defined in watchedCustomServices

Checklist:

  • Documentation added
  • Changelog updated
  • Tests added
  • Ready to be merged

@WtfJoke WtfJoke force-pushed the addWatchedCustomServiceClassSupport branch from 49e52dc to d95a4d9 Compare August 27, 2021 15:14
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #271 (d95a4d9) into main (673547d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #271      +/-   ##
============================================
- Coverage     75.71%   75.67%   -0.05%     
  Complexity      382      382              
============================================
  Files            80       80              
  Lines          1046     1044       -2     
  Branches         66       66              
============================================
- Hits            792      790       -2     
  Misses          219      219              
  Partials         35       35              
Impacted Files Coverage Δ
...haos/monkey/component/ChaosMonkeyRequestScope.java 93.87% <100.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673547d...d95a4d9. Read the comment docs.

@WtfJoke WtfJoke merged commit 422f7be into codecentric:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchedCustomService doesnt work with fully qualified class names
3 participants