Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApiDoc integration #327

Merged
merged 5 commits into from Oct 7, 2022
Merged

Add ApiDoc integration #327

merged 5 commits into from Oct 7, 2022

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Sep 2, 2022

What: Add springdoc-openapi integration

Why:

Show chaos monkey as a group in swagger ui

How:

configuration enabled by class and property

Checklist:

  • Documentation added
  • Changelog updated
  • [N/A] Tests added
  • Ready to be merged

@F43nd1r F43nd1r changed the title Add ApiDoc integration. Closes #326 Add ApiDoc integration Sep 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #327 (8a8366b) into main (eba9064) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #327      +/-   ##
============================================
- Coverage     77.31%   77.07%   -0.24%     
+ Complexity      449      447       -2     
============================================
  Files            84       85       +1     
  Lines          1093     1095       +2     
  Branches         74       74              
============================================
- Hits            845      844       -1     
- Misses          207      209       +2     
- Partials         41       42       +1     
Impacted Files Coverage Δ
...monkey/configuration/ChaosMonkeyConfiguration.java 89.65% <ø> (ø)
...configuration/ChaosMonkeyOpenApiConfiguration.java 0.00% <0.00%> (ø)
...ring/boot/chaos/monkey/assaults/MemoryAssault.java 90.90% <0.00%> (-1.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im quiet late to the party 🙈 but I've left some comments which I think makes it a bit easier to read (might be subjective).

chaos-monkey-docs/src/main/asciidoc/endpoints.adoc Outdated Show resolved Hide resolved
chaos-monkey-docs/src/main/asciidoc/endpoints.adoc Outdated Show resolved Hide resolved
chaos-monkey-docs/src/main/asciidoc/endpoints.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

@WtfJoke WtfJoke enabled auto-merge (squash) October 7, 2022 09:44
@WtfJoke WtfJoke merged commit d4ac9dc into codecentric:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants