Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always register outgoing watchers so they can be enabled later #402

Merged
merged 3 commits into from Oct 20, 2023

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Sep 29, 2023

What: Closes #393

Why: outgoing watchers were previously only registered when the respective property was set, but there are other ways to enable those.

How: Remove ConditionalOnProperty

Checklist:

  • Documentation added
  • Changelog updated
  • Tests added
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #402 (03aada4) into main (3b85a6b) will increase coverage by 2.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head 03aada4 differs from pull request most recent head 9f0185f. Consider uploading reports for the commit 9f0185f to get more accurate results

@@             Coverage Diff              @@
##               main     #402      +/-   ##
============================================
+ Coverage     78.06%   80.07%   +2.01%     
- Complexity      457      468      +11     
============================================
  Files            86       86              
  Lines          1094     1094              
  Branches         72       72              
============================================
+ Hits            854      876      +22     
+ Misses          204      183      -21     
+ Partials         36       35       -1     
Files Coverage Δ
...guration/ChaosMonkeyRestTemplateConfiguration.java 100.00% <ø> (ø)
...nfiguration/ChaosMonkeyWebClientConfiguration.java 100.00% <ø> (+100.00%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌿

@WtfJoke WtfJoke enabled auto-merge (squash) October 20, 2023 13:32
@WtfJoke WtfJoke merged commit 7cbf14f into codecentric:main Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RestTemplate watcher not working when enabled via watchers actuator rest endpoint
2 participants