fix(#2438): hide views in navigation bar (including about) (#2443)

* Fix #2438 view.isEnabled()

* fix(#2438): allow to hide menu elements

* remove weird "r"

* add missing i18n t function

* remove console.log

---------

Co-authored-by: Andreas Fritz <mail@andreasfritz.de>

spring-boot-admin-server-ui/src/main/frontend/components/sba-nav/sba-nav-item.vue

@@ -4,7 +4,6 @@
     :href="href"
     :target="target"
     class="sba-nav-item"
-    r
     rel="noopener noreferrer"
   >
     <slot />

spring-boot-admin-server-ui/src/main/frontend/composables/ViewRegistry.ts

@@ -45,5 +45,8 @@ export function useViewRegistry() {
 
       emitCustomRouteAddedEvent();
     },
+    getViewByName(name: string) {
+      return viewRegistry.views.find((view) => view.name === name);
+    },
   };
 }

spring-boot-admin-server-ui/src/main/frontend/shell/navbar.vue

@@ -61,8 +61,11 @@
         @locale-changed="changeLocale"
       />
       <sba-nav-usermenu v-if="sbaConfig.user" />
-      <sba-nav-item :to="{ name: 'about' }">
-        <FontAwesomeIcon icon="question-circle" />
+      <sba-nav-item v-if="isAboutEnabled" :to="{ name: 'about' }">
+        <FontAwesomeIcon
+          :aria-label="t('about.label')"
+          icon="question-circle"
+        />
       </sba-nav-item>
     </sba-navbar-nav>
   </sba-navbar>
@@ -94,8 +97,9 @@ defineProps({
   },
 });
 
-const { views } = useViewRegistry();
+const { views, getViewByName } = useViewRegistry();
 const i18n = useI18n();
+const t = i18n.t;
 
 const brand = sbaConfig.uiSettings.brand;
 
@@ -106,7 +110,8 @@ const topLevelViews = computed(() => {
         !view.parent &&
         !view.name?.includes('instance') &&
         !view.name?.includes('about') &&
-        !view.path?.includes('/instance')
+        !view.path?.includes('/instance') &&
+        view.isEnabled()
       );
     })
     .sort(compareBy((v) => v.order));
@@ -121,6 +126,7 @@ const topLevelViews = computed(() => {
   });
 });
 
+const isAboutEnabled = getViewByName('about')?.isEnabled();
 const changeLocale = (locale) => {
   i18n.locale.value = locale;
   moment.locale(locale);

spring-boot-admin-server-ui/src/main/frontend/viewRegistry.ts

@@ -32,6 +32,7 @@ const createI18nTextVNode = (label: string) =>
 // eslint-disable-next-line no-unused-vars
 type ViewFilterFunction = (view: SbaView) => boolean;
 type ViewConfig = {
+  isEnabled?: (obj?) => boolean;
   [key: string]: any;
 };