fix: user menu is visible even when no auth is active (#2426)

spring-boot-admin-server-ui/src/main/frontend/sba-config.ts

@@ -59,4 +59,4 @@ const DEFAULT_CONFIG = {
   },
 };
 
-export default merge(DEFAULT_CONFIG, window.SBA);
+export default merge(DEFAULT_CONFIG, global.SBA);

spring-boot-admin-server-ui/src/main/frontend/shell/navbar.spec.ts

@@ -0,0 +1,35 @@
+import { screen } from '@testing-library/vue';
+import { describe, expect, it, vi } from 'vitest';
+
+import Navbar from '@/shell/navbar.vue';
+import { render } from '@/test-utils';
+
+vi.mock('@/sba-config');
+
+describe('Navbar', function () {
+  it('User menu is visible, when a user is logged in', async function () {
+    const config = await vi.importActual('@/sba-config');
+    return {
+      default: {
+        ...config.default,
+        user: {
+          name: 'mail@example.com',
+        },
+      },
+    };
+
+    render(Navbar);
+
+    expect(screen.queryByText('mail@example.org')).toBeVisible();
+  });
+
+  it('User menu is hidden, when no user is logged in', async function () {
+    global.SBA = {
+      user: null,
+    };
+
+    render(Navbar);
+
+    expect(screen.queryByText('mail@example.org')).not.toBeInTheDocument();
+  });
+});

spring-boot-admin-server-ui/src/main/frontend/shell/navbar.vue

@@ -60,7 +60,7 @@
         :available-locales="AVAILABLE_LANGUAGES"
         @locale-changed="changeLocale"
       />
-      <sba-nav-usermenu />
+      <sba-nav-usermenu v-if="sbaConfig.user" />
       <sba-nav-item :to="{ name: 'about' }">
         <FontAwesomeIcon icon="question-circle" />
       </sba-nav-item>

spring-boot-admin-server-ui/src/main/frontend/test-utils.ts

@@ -9,16 +9,18 @@ import components from './components/index.js';
 import terms from './i18n/i18n.en.json';
 import SbaModalPlugin from './plugins/modal';
 
+import { createViewRegistry } from '@/composables/ViewRegistry';
 import ViewRegistry from '@/viewRegistry';
 
 export let router;
+createViewRegistry();
 
-export const render = (testComponent, options) => {
-  let routes = [{ path: '/', component: testComponent }];
+export const render = (testComponent, options?: any) => {
+  const routes = [{ path: '/', component: testComponent }];
   if (testComponent.install) {
-    let viewRegistry = new ViewRegistry();
+    const viewRegistry = new ViewRegistry();
     testComponent.install({ viewRegistry });
-    let routeForComponent = viewRegistry._toRoutes(
+    const routeForComponent = viewRegistry._toRoutes(
       viewRegistry.views,
       () => true
     )[0];
@@ -34,7 +36,7 @@ export const render = (testComponent, options) => {
     routes: routes,
   });
 
-  let renderOptions = merge(
+  const renderOptions = merge(
     {
       global: {
         plugins: [
@@ -56,6 +58,6 @@ export const render = (testComponent, options) => {
     },
     options
   );
-  let utils = tlRender(testComponent, renderOptions);
+  const utils = tlRender(testComponent, renderOptions);
   return { ...utils };
 };

spring-boot-admin-server-ui/tests/setup.js

@@ -18,5 +18,6 @@ global.ResizeObserver = vi.fn().mockImplementation(() => ({
 
 // runs a cleanup after each test case (e.g. clearing jsdom)
 afterEach(() => {
+  vi.clearAllMocks();
   cleanup();
 });