spring boot 1.x mapping result handle(in UI) maybe wrong?

[lagudomeze]

frontend mappings index.vue: isOldMetrics is true only if contentType equals "vnd.spring-boot.actuator.v2"

spring-boot-admin/spring-boot-admin-server-ui/src/main/frontend/views/instances/mappings/index.vue

Lines 93 to 97 in fd65e38

	if (res.headers['content-type'].includes('application/vnd.spring-boot.actuator.v2')) {
	this.contexts = res.data.contexts;
	} else {
	this.isOldMetrics = true;
	}

but with legacy convert to last spring boot api version

spring-boot-admin/spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/server/web/client/InstanceExchangeFilterFunctions.java

Lines 142 to 147 in fd65e38

	private static ClientResponse convertLegacyResponse(LegacyEndpointConverter converter, ClientResponse response) {
	return response.mutate().headers((headers) -> {
	headers.replace(HttpHeaders.CONTENT_TYPE,
	singletonList(ApiVersion.LATEST.getProducedMimeType().toString()));
	headers.remove(HttpHeaders.CONTENT_LENGTH);
	}).body(converter::convert).build();

As a result mapping is always old metric，convert is useless！

[lagudomeze]

maybe just change mappings/index.vue#L93 to v3 is fine?

[SteKoe]

Hi @lagudomeze,

thanks for filing this issue and providing a PR 😍!
We have checked your inquiry and tested it using Spring Boot 1.4 up to 3.0. Sadly, your change breaks accessing metrics on Spring Boot services using versions 2.0 and 2.1. Nevertheless, we have implemented your suggested change in a slightly different way and are now checking both ApiVersions (V2 -> Spring Boot 2.0/2.1, V3 -> Spring Boot >2.2).

Regards,
SteKoe