Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI extension is broken #2221

Closed
michael-wirth opened this issue Jan 17, 2023 · 3 comments
Closed

UI extension is broken #2221

michael-wirth opened this issue Jan 17, 2023 · 3 comments
Labels

Comments

@michael-wirth
Copy link

Spring Boot Admin Server information

  • Version:
    3.0.0M9

  • Spring Boot version:
    3.0.1

  • Configured Security:
    OAuth

  • Webflux or Servlet application:
    Servlet

Client information

  • Spring Boot versions:
    3.0.1, 2.7.7

  • Used discovery mechanism:
    Kubernetes

  • Webflux or Servlet application:
    Servlet

Description

The UI extension has been split up into 2 methods (install and configure).
The "configure" method is not yet used in the core application and I assume therefore not been tested.
I need to access the vue (app) instance not the mounted proxy (whatever that object is)

I strongly assume the "app" object and not the "vue" object should be passed on to the configure method.
https://github.com/codecentric/spring-boot-admin/blob/master/spring-boot-admin-server-ui/src/main/frontend/index.js#L101

Example

SBA.use({
  configure({vue}) {
    console.log(vue)
    vue.use({})
  },
  install({viewRegistry}) {
    console.log(viewRegistry)
  }
});
@michael-wirth
Copy link
Author

to get the vue/app instance it need to use

SBA.use({
  configure({vue}) {
    const app = vue.$.appContext.app
  }
})

is that the intention or is that an ugly hack?

@SteKoe
Copy link
Contributor

SteKoe commented Jan 20, 2023

In the upcoming release 3.0.0, app will be passed to configure as well.

@SteKoe SteKoe closed this as completed Jan 20, 2023
@georgerocha
Copy link

Hello
I have an Error with 3.0.0M9 regarding not been able to do a simple -v-for in the html elements...Is there some relation with this?
#2219

SteKoe added a commit that referenced this issue Mar 5, 2023
SteKoe added a commit that referenced this issue Mar 10, 2023
* fix: custom-uis do not work as expected

closes #2304, #2255, #2221, #2219

* add documentation

* copy routes.txt file to target directory to include custom routes in HomepageForwardingFilter

* remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants