Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading docs about background image #2428

Closed
genuss opened this issue Apr 30, 2023 · 2 comments · Fixed by #2432
Closed

Misleading docs about background image #2428

genuss opened this issue Apr 30, 2023 · 2 comments · Fixed by #2432
Labels

Comments

@genuss
Copy link
Contributor

genuss commented Apr 30, 2023

Spring Boot Admin Server information

  • Version: 3.0.x

  • Spring Boot version: 3.0x

Description

I looked for a property to disable background image appeared in 3.0 and found documentation about spring.boot.admin.ui.theme.background.enable, but it doesn't work and I couldn't find anything related to it in code.
Was it ever implemented? And if not, what's the intended behaviour: add property, or fix documentation?

@SteKoe
Copy link
Contributor

SteKoe commented May 2, 2023

Hi @genuss,

thanks for pointing this out! I have just pushed a change that fixes this behavior. The property is renamed to spring.boot.admin.ui.theme.background-enabled and will be respected in an upcoming release.

Regards,
SteKoe

@genuss
Copy link
Contributor Author

genuss commented May 3, 2023

Than you, @SteKoe ! I've checked your branch and it works like a charm. Looking forward for the new release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants