New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1146: Implement remember me functionality using spring security. #1197
Conversation
We should either autodetect the remember me support or either provide an option to configure it so that the box is hidden when not active. |
@@ -31,10 +35,21 @@ | |||
public class SecuritySecureConfig extends WebSecurityConfigurerAdapter { | |||
private final AdminServerProperties adminServer; | |||
|
|||
@Value("${spring.security.remember-me.timeout:1209600}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really a well known / standard property for configuring this? I can't find any docs on this. If not I'd suggest to remove this configuration option...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed that, since it is not a standard property.
@Value("${spring.security.remember-me.timeout:1209600}") | ||
private int REMEMBER_ME_TIMEOUT; | ||
|
||
@Value("${spring.security.remember-me.token:#{rememberMeTokenGenerator}}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really a well known / standard property for configuring this? I can't find any docs on this. If not I'd suggest to remove this configuration option...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed that, since it is not a standard property.
I have added a config to uiSettings that allows to enable or disable remember me checkbox. |
please have a look at the checkstyle violations |
I have implemented the requested feature "remember me #1146".