allow overriding registration client in blocking or reactive env #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteKoe
requested changes
Mar 11, 2022
...java/de/codecentric/boot/admin/client/config/SpringBootAdminClientAutoConfigurationTest.java
Outdated
Show resolved
Hide resolved
Fuud
force-pushed
the
allow-overriding-registration-client
branch
from
73dff1c
to
dd848d2
Compare
Done |
Fuud
force-pushed
the
allow-overriding-registration-client
branch
from
dd848d2
to
b14a296
Compare
SteKoe
approved these changes
Mar 18, 2022
erikpetzold
reviewed
Mar 18, 2022
|
|
||
| @Test | ||
| public void customBlockingClientInBlockingEnvironment() { | ||
| ReactiveWebApplicationContextRunner reactiveContextRunner = new ReactiveWebApplicationContextRunner() |
There was a problem hiding this comment.
This is still reactive environment ;)
Is working anyways, so we will merge and fix the test to prevent another one-week-roundtrip :)
SteKoe
added a commit
that referenced
this pull request
Mar 21, 2022
* origin/master: Switch to WebApplicationContextRunner in customBlockingClientInBlockingEnvironment. Allow overriding registration client in blocking or reactive env (#2004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.