Skip to content

Commit

Permalink
fix #495: passing suite object to event.suite.before/after handlers a…
Browse files Browse the repository at this point in the history
…nd helper's _beforeSuite/_afterSuite (#496)
  • Loading branch information
implico authored and DavertMik committed Apr 28, 2017
1 parent 62c2e7a commit 99af510
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions lib/interfaces/bdd.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ module.exports = function (suite) {
suite.beforeEach('codeceptjs.before', scenario.setup);
suite.afterEach('finialize codeceptjs', scenario.teardown);

suite.beforeAll('codeceptjs.beforeSuite', scenario.suiteSetup);
suite.afterAll('codeceptjs.afterSuite', scenario.suiteTeardown);
suite.beforeAll('codeceptjs.beforeSuite', () => scenario.suiteSetup(suite));
suite.afterAll('codeceptjs.afterSuite', () => scenario.suiteTeardown(suite));

return suite;
};
Expand Down
4 changes: 2 additions & 2 deletions lib/listener/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ module.exports = function () {
});

event.dispatcher.on(event.suite.before, function (suite) {
runAsyncHelpersHook('_beforeSuite', null, true);
runAsyncHelpersHook('_beforeSuite', suite, true);
});

event.dispatcher.on(event.suite.after, function (suite) {
runAsyncHelpersHook('_afterSuite', null, true);
runAsyncHelpersHook('_afterSuite', suite, true);
});

event.dispatcher.on(event.test.started, function (test) {
Expand Down
8 changes: 4 additions & 4 deletions lib/scenario.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ module.exports.teardown = function () {
event.emit(event.test.after);
};

module.exports.suiteSetup = function () {
module.exports.suiteSetup = function (suite) {
recorder.start();
event.emit(event.suite.before);
event.emit(event.suite.before, suite);
};

module.exports.suiteTeardown = function () {
module.exports.suiteTeardown = function (suite) {
recorder.start();
event.emit(event.suite.after);
event.emit(event.suite.after, suite);
};

function isGenerator(fn) {
Expand Down

0 comments on commit 99af510

Please sign in to comment.