Method added to capture screenshot for element #2507
Conversation
|
@suniljaiswal01 would be nice if you could support other helpers like puppeteet, playwright. I do believe they would have similar API to do so. |
@peterngtr Add support for other helpers |
|
Wow, that's good piece of work. Thank you very much. Looks good so far |
| @@ -1066,6 +1066,28 @@ class Nightmare extends Helper { | |||
| return this.browser.refresh(); | |||
| } | |||
|
|
|||
| /** | |||
| * {{> saveElementScreenshot }} | |||
There was a problem hiding this comment.
where is file with ext. mustache?
There was a problem hiding this comment.
Is there a command to generate .mustache files?, or do we have to manually create one
There was a problem hiding this comment.
Need add to manually. You can see example here
There was a problem hiding this comment.
And then run npm run docs
There was a problem hiding this comment.
@suniljaiswal01 yes. this is a placeholder for a shared template. Because all standard actions have same documentation, we store them in docs/webapi/*.mustache so when you add saveElementScreenshot you are referring to: docs/webapi/saveElementScreenshot.mustache file to be included as documentation.
So please add this documentation file and I am ready to merge this PR and make a release
There was a problem hiding this comment.
mustache file added
…moved from nightmare.js file.
# Conflicts: # docs/helpers/WebDriver.md
| sudo apt-get update | ||
| sudo apt-get install libgbm1 libgbm-dev libwoff1 libopus0 libwebp6 libwebpdemux2 libenchant1c2a libgudev-1.0-0 libsecret-1-0 libhyphen0 libgdk-pixbuf2.0-0 libegl1 libgles2 libevent-2.1-6 libnotify4 libxslt1.1 |
There was a problem hiding this comment.
any reasons why we update this?
| ## 2.6.7 | ||
|
|
||
| * Add REST helper into `standardActingHelpers` array #2474 by @PeterNgTr | ||
| * Add missing `--invert` option for `run-workers` command #2504 by @pablopaul | ||
| * [WebDriver] Introduce `forceRightClick` method #2485 bylsuniljaiswal01 | ||
| * [Playwright] Fix `setCookie` method #2491 by @bmbarker90 | ||
| * [TypeScript] Update compilerOptions.target to es2017 #2483 by @shanplourde | ||
| * [Mocha] Honor reporter configuration #2465 by @trinhpham | ||
|
|
There was a problem hiding this comment.
why do we remove this? 🤔
| @@ -1089,6 +1111,34 @@ class Nightmare extends Helper { | |||
| if (withinStatus !== false) await this._withinEnd(); | |||
| } | |||
|
|
|||
| async grabElementBoundingRect(locator, prop) { | |||
There was a problem hiding this comment.
you introduce this, would you mind adding it to the document?
|
@suniljaiswal01 seems like you didn’t rebase with latest changes of master branch (v 2.6.7) but with v2.6.6 |
|
@peterngtr is it ok if i create a new PR incorporating all the mentioned changes? |
|
Hey @suniljaiswal01 just go with any that fits you best. |
|
PR Created: #2521. Closing this PR |
Motivation/Description of the PR
Description of this PR, which problem it solves
User will be able to capture screenshot of specified element
Resolves #issueId (if applicable).
I screenshot the element #2401
Applicable helpers:
Type of change
Checklist:
npm run docs)npm run lint)npm test)