feat(timeout): Added timeouts for steps #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vorobeyko
force-pushed
the
add-timeouts-for-all-steps
branch
from
c4bf0cb
to
5bdb5dd
Compare
Vorobeyko
force-pushed
the
add-timeouts-for-all-steps
branch
from
5bdb5dd
to
05a4c5c
Compare
DavertMik
requested changes
Aug 2, 2020
lib/actor.js
Outdated
| @@ -116,7 +117,16 @@ function recordStep(step, args) { | |||
| event.emit(event.step.started, step); | |||
| step.startTime = Date.now(); | |||
| } | |||
| return val = step.run(...args); | |||
| console.log(step); | |||
There was a problem hiding this comment.
Suggested change
| console.log(step); |
kobenguyent
reviewed
Aug 3, 2020
| const config_run_config = (config, grep) => `${codecept_run} --config ${codecept_dir}/${config} ${grep ? `--grep "${grep}"` : ''}`; | ||
|
|
||
| describe('CodeceptJS Steps', () => { | ||
| it('should stop test, when step exceeded', (done) => { |
There was a problem hiding this comment.
I"m just curious if those tests can be written in async/await approach?
Vorobeyko
changed the base branch from
codeceptjs-v3.0
to
timeouts-for-steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)