-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split register type column #55
Split register type column #55
Conversation
@nuest I am redoing the code and thought of dropping the "type" and "venue" column for page of registers by venue since those columns are redundant. Tidyr's Is that okay with you? The json files will only contain the information showed on the page Refer to the top screenshot for the new look and the bottom screenshot of the old look. |
@nuest The code is ready for review again. Redid a lot of code on filtering the tables following your suggestion to use tidyr. Please refer to the description of the PR for what I changed. Can you create a separate issue for the JSON column order please? Prefer a separate issue because this PR already combines two PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, what a rewrite. Not easy to digest for me, but I find the new code quite readable. What do you think? Are you happier with the new approach?
Only had a few minor remarks. I'm fine if you go ahead and merge yourself after the final couple of changes, as I might be a bit busy the next days.
Good job!
Yes I am happy with the new approach. Simpler, easier to read and should be more efficient :)
Thanks! Just resolved the comments and i'll proceed with merging |
Solves issues:
Related register PR #98
In the
register.csv
the column "type" was split into into "type" and "venue" whereVenue = what is in brackets now
Type = outside of brackets
Changes made:
0.7.0
utils_filter_register_table.R
withutils_render_register_general.R
. The new filtering functionalities utilizes tidyr, dplyr and magrittr functionalities to filter the data which is more efficient than the previous method I used.MD_COLUMNS_WIDTHS
,MD_TITLES
,FILTER_COLUMN_NAMES
,NON_REG_TITLE_FNS
,JSON_COLUMNS
and moreman