Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore PHP namespace/use statements #245

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Ignore PHP namespace/use statements #245

merged 2 commits into from
Oct 9, 2017

Conversation

brynary
Copy link
Member

@brynary brynary commented Oct 9, 2017

No description provided.

@wfleming wfleming changed the title [WIP] Ignore PHP namespace/use statements Ignore PHP namespace/use statements Oct 9, 2017
@codeclimate-hermes codeclimate-hermes requested review from wilson and removed request for codeclimate-hermes October 9, 2017 19:18
wilson
wilson approved these changes Oct 9, 2017
View reviewed changes
Copy link

@wilson wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
The heredoc is a candidate for "squiggly-arrow" <~EOF, so the php code could be indented to match the Ruby. Fine as-is as well.

@wfleming
Copy link
Contributor

wfleming commented Oct 9, 2017

Good point, @wilson, we are using a new enough Ruby here now so I updated that. I will merge on green.

@wfleming wfleming merged commit e963f62 into channel/cronopio Oct 9, 2017
@wfleming wfleming deleted the brynary/php-imports branch October 9, 2017 20:16
@tillkruss tillkruss mentioned this pull request Jul 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilson wilson wilson approved these changes

Assignees

@wfleming wfleming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brynary @wfleming @wilson