Treat 409 upload status as warning, not error #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on CI setup, it is possible that CI can run multiple times for the same commit. The `v1/test_reports` endpoint returns 409 when receiving a request to create a test report when one already exists for the commit. This exception currently is bubbled through the reporter causing the run to ultimately exit with status 1. This changes the behavior to treat the 409 status separately as a "warning" rather than an "error," which better reflects the situation. The exit status in this case will be 0 and a warning will be logged. Another alternative considered was changing the endpoint to be create-or-update, but that has been deferred for now.
|
|
wfleming
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on CI setup, it is possible that CI can run multiple times for
the same commit. The
v1/test_reportsendpoint returns 409 whenreceiving a request to create a test report when one already exists for
the commit. This exception currently is bubbled through the reporter
causing the run to ultimately exit with non-zero code.
This changes the behavior to treat the 409 status separately as a
"warning" rather than an "error," which better reflects the situation.
The exit status in this case will be 0 and a warning will be logged.
Another alternative considered was changing the endpoint to be
create-or-update, but that has been deferred for now.
before:
after: