Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat 409 upload status as warning, not error #268

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Treat 409 upload status as warning, not error #268

merged 1 commit into from
Dec 4, 2017

Commits on Dec 4, 2017

  1. Treat 409 upload status as warning, not error 

    Depending on CI setup, it is possible that CI can run multiple times for
the same commit. The `v1/test_reports` endpoint returns 409 when
receiving a request to create a test report when one already exists for
the commit. This exception currently is bubbled through the reporter
causing the run to ultimately exit with status 1.

This changes the behavior to treat the 409 status separately as a
"warning" rather than an "error," which better reflects the situation.
The exit status in this case will be 0 and a warning will be logged.

Another alternative considered was changing the endpoint to be
create-or-update, but that has been deferred for now.
    Chris Hulton committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    8e1d26b View commit details
    Browse the repository at this point in the history