New command "show-coverage" #424
Conversation
…ts the coverage information in a readable way
|
|
|
Hi @caiosba - thanks for the PR. I've just put this in the queue for our engineers to review. 👌 |
cmd/show-coverage.go
Outdated
| json.Unmarshal([]byte(string(dat)), &result) | ||
| line_counts := result["line_counts"].(map[string]interface{}) | ||
| header := "Coverage: %.2f%% (%d/%d lines covered, %d missing)" | ||
| fmt.Println(fmt.Sprintf(header, result["covered_percent"], int(line_counts["covered"].(float64)), int(line_counts["total"].(float64)), int(line_counts["missed"].(float64)))) |
There was a problem hiding this comment.
The body of this function is a bit dense. Do you mind extracting a few new functions to smooth out the read?
cmd/show-coverage.go
Outdated
| if getLineCount(result, "missed") > 0 { | ||
|
|
||
| fmt.Println("Uncovered lines by file:") | ||
| files := result["source_files"].([]interface{}) | ||
|
|
||
| for _, file_obj := range files { | ||
| file := file_obj.(map[string]interface{}) | ||
| if file["covered_percent"].(float64) < 100 { | ||
| printUncoveredLinesFromFile(file) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
What about another one here? 😁
There was a problem hiding this comment.
Another one what? 😁
There was a problem hiding this comment.
function!
I would say something like printUncoveredLines?
There was a problem hiding this comment.
Ah yes, makes sense... done! :)
|
Looks like both sets of tests failed:
|
I can't see which part of my code would trigger this failure... can I be sure it's working for the main branch? BTW the failure I see is that the double quotes are escaped. |
|
I'll try to run the tests locally to see. |
|
I was able to reproduce the test failure by running them in the |
|
@caiosba thanks for looking into it, wasn't finding the time to dig. |
We wanted to show the coverage results easily in our Travis job output log, and we had two parallel jobs, one with the unit tests and the other one with the functional tests. We use the
sum-coveragecommand to combine those two into a single coverage file.This PR adds a new command
show-coveragewhich parses that single coverage file and outputs the coverage information, for example, coverage percentage, number of covered lines, total number of lines, number of missing lines and which lines from which files are not covered. Example output: