Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add websocket port forward for Vagrant #2611

Merged
merged 1 commit into from Apr 3, 2015

Conversation

AlanHohn
Copy link
Contributor

@AlanHohn AlanHohn commented Apr 1, 2015

Forward the websocket port out of the virtual machine so the browser can connect to it

nwinter added a commit that referenced this pull request Apr 3, 2015
add websocket port forward for Vagrant
@nwinter nwinter merged commit d6f6e3b into codecombat:master Apr 3, 2015
@nwinter
Copy link
Contributor

nwinter commented Apr 3, 2015

@AlanHohn @popey456963 nice work on the Vagrant setup! How's it going now–still any known issues, or pretty solid?

@popey456963
Copy link
Contributor

@AlanHohn gets all the credit, I've changed a whole word of code.

In terms of progress, vagrant might be getting to the stage where we can release it to the public. This pull request in particular, makes it a lot easier to use, allowing the client to get to the website. I'm not sure which OS Alan is using, but on Windows it works well.

The user will only need to install vagrant + an ssh client of their choice. Then it should be as simple as vagrant up.

@popey456963
Copy link
Contributor

Note that they'll only need an ssh client if they wish to access the box once it is up.

@AlanHohn AlanHohn deleted the vagrant-ws-port branch April 3, 2015 20:12
@AlanHohn
Copy link
Contributor Author

AlanHohn commented Apr 3, 2015

I'm mostly using a Mac, but did some testing on Windows as well. I installed Git for Windows and got SSH that way.

I am running into one issue, at least on Mac, which is that brunch doesn't appear to pick up my changes if I make them on the host. If I SSH into the VM and make a change it gets picked up right away.

So it's not quite at the point where it's easier for a novice user, but it's close. Certainly it's easier for me as someone who knows more about VMs and Linux than about Node.

@popey456963
Copy link
Contributor

Ah, we definitely need to make a note of that - I reckon most (at least some) will have only installed Git_hub_ for windows, which does not include SSH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants