Change the end time on the end date of licenses created #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/views/LicensorViewComponent.vue
Outdated
| @@ -222,6 +222,7 @@ module.exports = Vue.extend({ | |||
| user = yield api.users.getByEmail({email}) | |||
| attrs = data | |||
| attrs.maxRedeemers = parseInt(data.maxRedeemers) | |||
| data.endDate = data.endDate + " " + "23:59" # Otherwise, it ends at 12 am by default which does not include the date indicated | |||
There was a problem hiding this comment.
Can we use the attrs variable instead of the data variable here and the next 2 lines, like AdministerUserModel.coffee?
attrs.endDate = attrs.endDate + " " + "23:59"
There was a problem hiding this comment.
Yeah, we can do that to make it similar to AdministerUserModel.coffee.
Do you want me to change it in this PR?
There was a problem hiding this comment.
Yea, if you're going to change it please do it in the PR so you can squash and merge into one commit in master and keep things clean. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.