Implement Min Health Restriction #4803
Conversation
app/lib/world/world.coffee
Outdated
| @@ -260,6 +260,11 @@ module.exports = class World | |||
| system.start @thangs | |||
| catch err | |||
| console.error "Error starting system!", system, err | |||
| # Silently clamp health after systems run. | |||
| hero = _.find(@thangs, (thang) -> thang.id == 'Hero Placeholder') | |||
There was a problem hiding this comment.
Not sure if this is the best way to locate the hero.
There was a problem hiding this comment.
This works. You can also shorten a bit:
hero = _.find @thangs, id: 'Hero Placeholder'
app/lib/world/world.coffee
Outdated
| @@ -260,6 +260,14 @@ module.exports = class World | |||
| system.start @thangs | |||
| catch err | |||
| console.error "Error starting system!", system, err | |||
| # Silently clamp health after systems run. | |||
| hero = _.find(@thangs, (thang) -> thang.id == 'Hero Placeholder') | |||
| if hero? | |||
There was a problem hiding this comment.
Should this be refactored out?
It's not long enough and doesn't need to be called anywhere else currently.
There was a problem hiding this comment.
I would just put it into its own world method here called clampHeroHealth or something like that.
app/lib/world/world.coffee
Outdated
| @@ -260,6 +260,11 @@ module.exports = class World | |||
| system.start @thangs | |||
| catch err | |||
| console.error "Error starting system!", system, err | |||
| # Silently clamp health after systems run. | |||
| hero = _.find(@thangs, (thang) -> thang.id == 'Hero Placeholder') | |||
There was a problem hiding this comment.
This works. You can also shorten a bit:
hero = _.find @thangs, id: 'Hero Placeholder'
app/lib/world/world.coffee
Outdated
| @@ -260,6 +260,14 @@ module.exports = class World | |||
| system.start @thangs | |||
| catch err | |||
| console.error "Error starting system!", system, err | |||
| # Silently clamp health after systems run. | |||
| hero = _.find(@thangs, (thang) -> thang.id == 'Hero Placeholder') | |||
| if hero? | |||
There was a problem hiding this comment.
I would just put it into its own world method here called clampHeroHealth or something like that.
| hero.maxHealth = Math.max(hero.maxHealth, level.recommendedHealth) | ||
| if level.maximumHealth? | ||
| hero.maxHealth = Math.min(hero.maxHealth, level.maximumHealth) | ||
| hero.health = hero.maxHealth |
There was a problem hiding this comment.
I just realized we only want to do this if we are in classroom mode, so when level.type is 'course'. In home mode, they still need to actually have that much health.
There was a problem hiding this comment.
Thanks for the review and clarification.
recommendedHealthmaximumHealthto schemas.