All levels unlocked when no course instance #5027
Conversation
…//github.com/codecombat/codecombat into all-levels-unlocked-when-no-courseInstanceId
There was a problem hiding this comment.
Will this @annotateLevels call break anything since we're initializing level.locked sooner than previously?
https://github.com/codecombat/codecombat/blob/0c98ddb/app/views/play/CampaignView.coffee#L700
It doesn't seem like we should initialize all the levels to locked and hidden for every render, especially if @courseStats is loaded since that will make determineNextLevel overwrite this initial data. Let's separate one-time initializations from frequent render calls.
Moving classroom-specific level initialization elsewhere would also prevent us from adding more complexity to annotateLevels. As written, these changes are mixing classroom and home logic within the main loop of annotateLevels. In general, we should try to keep classroom and home logic as isolated as possible.
…https://github.com/codecombat/codecombat into all-levels-unlocked-when-no-courseInstanceId" This reverts commit 0c98ddb, reversing changes made to 71e3895.
As a quick fix, we are locking and hiding all levels when courseInstance-Id is not available. As an improvement, created a task to tackle in future to query for courseInstanceId if it is missing and direct the user to the right course instance in this scenario -
Redirect user to right course Instance when courseInstanceId is removed from query variable in the url
Now we are locking and hiding all levels before the code for unlocking the right levels is executed. So, the flashing of unlocked levels before the map gets loaded completely does not happen anymore!