Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificates-view.jade #5074

Closed
wants to merge 1 commit into from
Closed

Update certificates-view.jade #5074

wants to merge 1 commit into from

Conversation

Chaboi45
Copy link
Contributor

@Chaboi45 Chaboi45 commented Dec 8, 2018

Changed "Print" to "Print Certificate"

Changed "Print" to "Print Certificate"
Copy link
Contributor Author

@Chaboi45 Chaboi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two problems:

  1. Since I don't have write access to this certain file, it returns this PR as a conflict with the base repo.
  2. Seems like I deleted my old forked repo during the check, Travis got confused. :(

Copy link
Contributor Author

@Chaboi45 Chaboi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change will push.

@@ -30,7 +30,7 @@ style.

.style-flat
.menu
.print-btn.btn.btn-success Print
.print-btn.btn.btn-success Print certificate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, capitalization error here. Will fix.

Suggested change
.print-btn.btn.btn-success Print certificate
.print-btn.btn.btn-success Print Certificate

@mrfinch
Copy link
Contributor

mrfinch commented Feb 15, 2022

@Chaboi45 , is this relevant still?

@Chaboi45
Copy link
Contributor Author

@mrfinch I think this PR isn't needed anymore. I'll close. 👍

@Chaboi45 Chaboi45 closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants