Move Commit.report to GCS
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #10 +/- ##
=======================================
- Coverage 95.23 95.18 -0.05
=======================================
Files 559 554 -5
Lines 14030 14004 -26
=======================================
- Hits 13361 13329 -32
- Misses 669 675 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
force-pushed
the
gio/migrate-commits-report-to-gcs
branch
from
e8f3d33
to
e744a2a
Compare
This is the API changes that will move `Commit.report` to GCS. - Alter `report` field to be `_report` (the db_field) and `_report_storage_path` (the archive_field) - Create the associated migration - Turn `report` into an `ArchiveField` - Adjust tests There were some minor tweaks to `ArchiveField`, and I had to drop the typehint in `get_repository` to avoid circular dependencies I also decided to move the config lookup of `should_write_data_to_storage` to a shared function, given they will be similar for all fields. Notice we can still turn individual fields on/off independently, but the "only_codecov" and "repo_ids" are shared now. Every field still has their own `should_write_data_to_storage` to account for differences in the objects, and allow for individual behavior. Also less duplicated code, yay Something else I had to do is include an `encoder` in the `ArchiveField` so we can continue using the same encoder for the db_field and the archive_field
giovanni-guidini
force-pushed
the
gio/migrate-commits-report-to-gcs
branch
from
e744a2a
to
8eb5dab
Compare
| return master_write_switch and ( | ||
| is_codecov_repo or is_in_allowed_repos or not only_codecov | ||
| return should_write_data_to_storage_config_check( | ||
| master_switch_key="report_details_files_array", |
There was a problem hiding this comment.
Should we have a new config key for commits.report?
There was a problem hiding this comment.
I think we should, yes. I used "commit_report" as the master key.
(this file is the ReportDetails one btw)
scott-codecov
approved these changes
Jul 20, 2023
Classic CTRL+V + CTRL+C without fixing it. Now it's fixed.
scott-codecov
added a commit
that referenced
this pull request
Jul 21, 2023
* main: Add api_health endpoint Move `Commit.report` to GCS (#10) fix: Set SameSite=None; Secure for sessionid cookie delete unnecessary redacted secrets from config Get rid of reduntant validation error Update shared. (#20) fix: Handle no current owner in GraphQL resolvers Return and catch validation error Addressed feedback Add mutation to start trial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the API changes that will move
Commit.reportto GCS. Missing tests on the model.Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.