Update shared. #20
Merged
Update shared. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating shared to codecov/shared@8573d97 because it has the fix for https://codecov.sentry.io/issues/4326038619/?project=5215654&query=is%3Aunresolved&referrer=issue-stream&stream_index=0 THe changes to google auth libs came from `pip compile`... I thought best leave them there.
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=====================================
Coverage 95.22 95.22
=====================================
Files 556 556
Lines 13991 13991
=====================================
Hits 13322 13322
Misses 669 669
Flags with carried forward coverage won't be shown. Click here to find out more. |
scott-codecov
approved these changes
Jul 20, 2023
giovanni-guidini
added a commit
that referenced
this pull request
Jul 21, 2023
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS. I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis. Ticket: [platform-team #20](codecov/engineering-team#20)
scott-codecov
added a commit
that referenced
this pull request
Jul 21, 2023
* main: Add api_health endpoint Move `Commit.report` to GCS (#10) fix: Set SameSite=None; Secure for sessionid cookie delete unnecessary redacted secrets from config Get rid of reduntant validation error Update shared. (#20) fix: Handle no current owner in GraphQL resolvers Return and catch validation error Addressed feedback Add mutation to start trial
giovanni-guidini
added a commit
that referenced
this pull request
Jul 24, 2023
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS. I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis. Ticket: [platform-team #20](codecov/engineering-team#20)
giovanni-guidini
added a commit
that referenced
this pull request
Jul 24, 2023
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS. I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis. Ticket: [platform-team #20](codecov/engineering-team#20)
giovanni-guidini
added a commit
that referenced
this pull request
Jul 24, 2023
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS. I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis. Ticket: [platform-team #20](codecov/engineering-team#20)
giovanni-guidini
added a commit
that referenced
this pull request
Jul 25, 2023
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS. I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis. Ticket: [platform-team #20](codecov/engineering-team#20)
giovanni-guidini
added a commit
that referenced
this pull request
Jul 25, 2023
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS. I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis. Ticket: [platform-team #20](codecov/engineering-team#20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating shared to codecov/shared@8573d97 because it has the fix for https://codecov.sentry.io/issues/4326038619/?project=5215654&query=is%3Aunresolved&referrer=issue-stream&stream_index=0
THe changes to google auth libs came from
pip compile... I thought best leave them there.Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.