ref: drop ownerprofile terms agreement columns #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 95.54% 95.45% -0.10%
==========================================
Files 594 595 +1
Lines 14814 14821 +7
==========================================
- Hits 14154 14147 -7
- Misses 660 674 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes |
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
=======================================
+ Coverage 95.44 95.45 +0.01
=======================================
Files 709 710 +1
Lines 15214 15222 +8
=======================================
+ Hits 14521 14529 +8
Misses 693 693
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JerrySentry
commented
Sep 21, 2023
| @@ -1,108 +0,0 @@ | |||
| from datetime import datetime | |||
There was a problem hiding this comment.
Remove this test for previous migration since these columns are deleted in this change anyways.
JerrySentry
commented
Sep 21, 2023
| @@ -104,6 +104,8 @@ def resolve_tracking_data(current_user, _, **kwargs): | |||
| @me_bindable.field("termsAgreement") | |||
| @sync_to_async | |||
| def resolve_terms_agreement(current_owner: Owner, _, **kwargs) -> Optional[bool]: | |||
| if current_owner.user is None: | |||
There was a problem hiding this comment.
Apparently it is possible for user to be null through impersonation?
adrian-codecov
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Remove two columns from ownerprofile table that is no longer used, current data in those columns are migrated to the new columns in the user table, though the data is not meaningful at the moment anyways until we turn on the agreements feature on the frontend.
Links to relevant tickets
codecov/engineering-team#390
What does this PR do?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.