Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate label analysis #23

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Reactivate label analysis #23

merged 4 commits into from
Jul 25, 2023

Conversation

giovanni-guidini
Copy link
Contributor

Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS.
I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis.

Ticket: platform-team #20

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #23 (59fdbaa) into main (b76bae4) will increase coverage by 0.05%.
The diff coverage is 96.78%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

@@           Coverage Diff           @@
##            main     #23     +/-   ##
=======================================
+ Coverage   95.22   95.27   +0.05     
=======================================
  Files        560     677    +117     
  Lines      14050   14346    +296     
=======================================
+ Hits       13379   13668    +289     
- Misses       671     678      +7     
Flag Coverage Δ
smart-labels 93.50% <96.78%> (?)
unit 95.21% <96.78%> (-0.01%) ⬇️
unit-latest-uploader 95.21% <96.78%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
billing/constants.py 100.00% <ø> (ø)
...uth/management/commands/set_trial_status_values.py 90.47% <90.47%> (ø)
plan/service.py 93.75% <93.75%> (ø)
api/internal/owner/serializers.py 100.00% <100.00%> (ø)
billing/helpers.py 100.00% <100.00%> (ø)
billing/models.py 100.00% <100.00%> (ø)
billing/views.py 95.27% <100.00%> (-0.07%) ⬇️
codecov_auth/admin.py 93.06% <100.00%> (ø)
...s/owner/interactors/get_uploads_number_per_user.py 100.00% <100.00%> (ø)
...cov_auth/commands/owner/interactors/start_trial.py 100.00% <100.00%> (ø)
... and 12 more

... and 145 files with indirect coverage changes

@giovanni-guidini giovanni-guidini force-pushed the gio/reactivate-ats branch 2 times, most recently from 31343e3 to 5de56c2 Compare July 24, 2023 13:46
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS.
I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis.

Ticket: [platform-team #20](codecov/engineering-team#20)
Notice that I put label analysis and the upload associated with static analysis and called the whole thing ATS.
I think that is the most accurate metric as the total overhead for the tests, technically, also includes static analysis.

Ticket: [platform-team #20](codecov/engineering-team#20)
@giovanni-guidini giovanni-guidini merged commit afd582c into main Jul 25, 2023
8 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/reactivate-ats branch July 25, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants