Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emit pubsub event when org token is updated #241

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

scott-codecov
Copy link
Contributor

@scott-codecov scott-codecov commented Nov 13, 2023

Similar to #215
Emit a pubsub event whenever an org token is saved.

Depends on https://github.com/codecov/shelter/pull/58

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81b13ba) 95.62% compared to head (b57d19f) 95.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   95.62%   95.63%           
=======================================
  Files         605      605           
  Lines       15551    15567   +16     
=======================================
+ Hits        14871    14887   +16     
  Misses        680      680           
Flag Coverage Δ
unit 95.63% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81b13ba) 95.53% compared to head (b57d19f) 95.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #241     +/-   ##
=======================================
+ Coverage   95.53   95.54   +0.01     
=======================================
  Files        719     719             
  Lines      15958   15974     +16     
=======================================
+ Hits       15245   15261     +16     
  Misses       713     713             
Flag Coverage Δ
unit 95.63% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 95.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scott-codecov scott-codecov merged commit 63bcae7 into main Nov 17, 2023
17 of 19 checks passed
@scott-codecov scott-codecov deleted the scott/sync-org-token branch November 17, 2023 15:13
scott-codecov added a commit that referenced this pull request Nov 17, 2023
* main:
  feat: Emit pubsub event when org token is updated (#241)
  perf: use new get_file_totals() report method for BranchContents (#252)
  feat: adjust benefits for team plan (#253)
  fix: Adjust Team plan pricing (#805) (#243)
  feat: Add Sentry user to admin panel (#702) (#232)
  metrics: update shared + add sentry traces to BranchContents GraphQL query path (#251)
  Use the same sentry version (#247)
  feat(logging): change access logging format to JSON (#249)
  Use alpine 3.18 (#245)
  fix(launchscripts): delete contents of prometheus multiproc dir, not dir itself (#244)
  Make migration info log less confusing (#221)
  Fix urllib and opentelemetry-instrumentation dependencies (#213)
  Updating workflows (#242)
  fix: Handle Shelter storage paths in upload download handler (#234)
  feat: Modify billing for Team plan (#637) (#225)
  fix: Upgrade Django version to fix security vulnerabilities (#239)
  Update small badge (#238)
  Send github oauth access token expiry with cookie (#237)
  fix: Skip login if GitHub OAuth does not return access_token (#236)
trent-codecov added a commit that referenced this pull request Nov 17, 2023
* metrics: update shared + add sentry traces to BranchContents GraphQL query path (#251)

* metrics: add sentry traces to BranchContents GraphQL query path

* update shared to use merge commit sha

* feat: Add Sentry user to admin panel (#702) (#232)


Add Sentry user to Django admin dashboard, can search and update Sentry user by name/email and link to the associated User object. Hides access/refresh token fields.

* fix: Adjust Team plan pricing (#805) (#243)

* feat: adjust benefits for team plan (#253)

* perf: use new get_file_totals() report method for BranchContents (#252)

* perf: use new get_file_totals() report method for BranchContents

* fix tests; update shared + expose fn on mock

* update shared to point at merge commit

* feat: Emit pubsub event when org token is updated (#241)

Co-authored-by: Trent Schmidt <trent@codecov.io>

* fix: Use GitHub integration access token when using GH app (#240)

* fix: Fallback to OAuth bot token when installation token fails (#255)

* fix: Fallback to OAuth bot token when installation token fails

* Rename test

* Shared update

---------

Co-authored-by: matt-codecov <137832199+matt-codecov@users.noreply.github.com>
Co-authored-by: JerrySentry <142266253+JerrySentry@users.noreply.github.com>
Co-authored-by: Adrian <adrian@codecov.io>
Co-authored-by: scott-codecov <scott@codecov.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants